Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support DMLs with named schema #262

Merged
merged 2 commits into from
Jan 12, 2025
Merged

Support DMLs with named schema #262

merged 2 commits into from
Jan 12, 2025

Conversation

apstndb
Copy link
Contributor

@apstndb apstndb commented Jan 9, 2025 •
edited
Loading

This PR adds support of named schema in DMLs.

Breaking changes

  • TableName in Update, Delete, Insert are changed to *ast.Path from *ast.Ident.

Related Issues

This was referenced Jan 9, 2025
Open
Open
makenowjust
makenowjust approved these changes Jan 12, 2025
View reviewed changes
Copy link
Collaborator

@makenowjust makenowjust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@makenowjust makenowjust merged commit a0ea6a5 into cloudspannerecosystem:main Jan 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makenowjust makenowjust makenowjust approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support named schemas in DMLs
2 participants
@apstndb @makenowjust